Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: missing default protocol when using dest_port property #308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed: missing default protocol when using dest_port property #308

wants to merge 2 commits into from
+16 −4

Conversation

decoyjoe
Copy link
Contributor

Description

Fixes an issue where the firewall_rule resource doesn't default the protocol to tcp when using the dest_port property.

Issues Resolved

Fixes #307

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@decoyjoe decoyjoe requested a review from a team as a code owner January 27, 2025 21:14
@bmhughes bmhughes added Bug Something isn't working Release: Patch Release to Chef Supermarket as a version patch when merged labels Jan 29, 2025
@bmhughes bmhughes enabled auto-merge (squash) January 29, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmhughes bmhughes bmhughes approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Release: Patch Release to Chef Supermarket as a version patch when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protocol method is not defaulting to :tcp and is required
2 participants
@decoyjoe @bmhughes