Issue #17 Add rendering mode using blocks of columns instead of bars #18
Conversation
|
Screenshots:
|
|
Closes #17 |
duviz.py
Outdated
| depth: int, | ||
| ) -> List[str]: | ||
| """Render a single node""" | ||
| def _truncate(s, maxlen): |
There was a problem hiding this comment.
this can be a top-level helper function I think
| ): | ||
| super().__init__(max_depth, size_formatter) | ||
| self.height = height | ||
| self.color_mode = color_mode |
There was a problem hiding this comment.
If I understand correctly the non color-mode is also using color escape codes ("monochrome rendering").
Isn't it possible to have a real non-color pure-ASCII renderer, e.g. to allow usage in context where there is no color support (e.g. a text/markdown file, ...)?
There was a problem hiding this comment.
Done, will upload new revision soon (hopefully).
duviz.py
Outdated
| else: | ||
| prefix = "" | ||
| suffix = "" | ||
| left = "█" |
There was a problem hiding this comment.
Why this special character? can't this just be done with pure ASCII, or even just a space?
There was a problem hiding this comment.
A space could also work as a separator, but it would need to be inverted. While the "█" character is outside of seven-bit ASCII, it is present in all monospace fonts I encountered, even in Linux's text-mode console, probably because it was a part of CP437 of the original IBM PC.
On the other hand, I realized that the "▁" character (which was also used in this revision) is missing from CP437 and has no corresponding glyph in Linux's text-mode console either. For this reason I have been working on a new revision that produces a less attractive but more compatible output that looks like this:
I still need to do some finishing touches before I can upload this new revision though.
duviz.py
Outdated
| size_str, | ||
| ] | ||
| else: | ||
| assert False |
There was a problem hiding this comment.
assert False will not give a very helpful error message. I think this could at least be raise ValueError(text_lines)
|
Thanks for the review. A quick status update, since I couldn't find the time to finish the new revision, sorry about that: |
There was a problem hiding this comment.
Today I was finally able to finish the next revision, sorry about the delay. I got rid of the "▁" characters as they did not show up in the text-mode linux console and also of the ANSI sequences in non-color mode. On the other hand, I added "▒" as a background filling pattern to make the content stand out more. While this character is out of the 7-bit ASCII range, it is available in every fixed-width font I encountered probably due to it being part of IBM's CP437 encoding.
I also rebased to the latest committed revision which renamed the class attributes of the Colorizer class to start with an underscore and therefore be private by convention. My code, however, needs to use these class attributes directly as the current Colorizer API only makes sense for line-based rendering and not for column-based. Please let me know what you would consider the nicest solution to this problem.
No description provided.