reduce php binary to minimum #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Oct 16, 2024
| @@ -40,7 +40,7 @@ WORKDIR /src/sqlite | |||
| RUN emcc -Oz -DSQLITE_OMIT_LOAD_EXTENSION -DSQLITE_DISABLE_LFS -DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_THREADSAFE=0 -DSQLITE_ENABLE_NORMALIZE -c sqlite3.c -o sqlite3.o | |||
|
|
|||
| FROM build_tool as php_src | |||
| ARG PHP_BRANCH=PHP-8.3.0 | |||
| ARG PHP_BRANCH=PHP-8.4.0 | |||
There was a problem hiding this comment.
Suggested change
| ARG PHP_BRANCH=PHP-8.4.0 | |
| ARG PHP_BRANCH=PHP-8.4 |
(It would be even better to use the latest tag).
|
You could likely reduce the size more by compressing the final file using these tricks: https://rustwasm.github.io/book/reference/code-size.html |
|
actually everything is built-in emcc: https://emscripten.org/docs/optimizing/Optimizing-Code.html#how-to-optimize-code and I found -O2 to be the most optimized when it comes to building PHP. The thing we need to do is serve the .wasm gzipped. Also emcc already uses wasm-opt. |
|
I'm interested to build this reproducibly with Nix! |
|
@drupol what's the problem with Nix it should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone this branch, then run: