feat: radix image report #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskbx
force-pushed
the
feat/radix-image-report
branch
from
f2c203a to
c09438e
Compare
Mayaryin
reviewed
Jan 10, 2025
There was a problem hiding this comment.
In my opinion, this component could be merged with SuccessScreen.tsx into one reusable component like "MessageScreen" or so, which would make it easer to apply changes in layout later. But this is not a blocker :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the report feature back, rebuilt with radix. I decided to go with a popover menu instead of an extra dialog to improve the overall user-experience. This means the report is not accessible via it's own URL anymore, as it is rather an action inside of the image fullscreen view instead of its own page. I doubt that there are any deep-links, but just in case, there's a (hacky) redirect in place. One interesting thing happens, when reporting an image: it will instantly be flagged as needs-moderation and thus is not visible in Wheelmap anymore. That's why, there is quite some edge-case code in the report-popover when closing the success-message. I also cleaned up a lot of old photo-related stuff that seemed to be not in use anymore.
before testing locally
You might need to run
npm cias it based on the file-upload branch which introduced new dependencies.