Update: Contrast Edits #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes mods that are no longer on the hub.
- Updated listing.blade.php - Updated show.blade.php To give a summary of what is changed, I basically updated some bg-white to be bg-gray-50 and darken some other text/colors. I made some blues more blue, and such. It's very minor changes, and should not really be noticeable except for contrasting each other.
|
|
|
Ahah! Git auto merged, I need to remake this PR how fun. |
|
These look good! When you think it's in a good place mark it for review. :) |
|
I'll mark it, I can always just make another PR for any other edits tbh. You might have to cherry pick also, since I accidently merged main into this.. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To give a summary of what is changed, I basically updated some bg-white to be bg-gray-50 and darken some other text/colors. I made some blues more blue, and such. It's very minor changes, and should not really be noticeable except for contrasting each other.
Default:
Light
Dark
Updated:
Light
Dark
Keep this PR open so I can make edits and still verify things.
On the off chance these are not dark/light enough edits can be made to fix that.
Also I can edit other views to follow the same scheme, in this same PR.