Replace fatal with panic (#15)

* Replace fatal with panic

* Add nolint to non-even number of args

fields.go

@@ -1,9 +1,7 @@
 package spcontext
 
 import (
-	stdlog "log"
-
-	"github.com/pkg/errors"
+	"fmt"
 )
 
 // Fields represents and contains structure metadata.
@@ -14,9 +12,10 @@ type Fields struct {
 }
 
 // With creates a new child Fields with additional fields.
+// Panics if odd number of arguments were passed or key(first value of each pair) is not a string.
 func (fields *Fields) With(kvs ...interface{}) *Fields {
 	if len(kvs)%2 != 0 {
-		stdlog.Fatalf("%+v", errors.New("invalid Fields.With call: odd number of arguments"))
+		panic("invalid Fields.With call: odd number of arguments")
 	}
 
 	keys := make([]string, len(kvs)/2)
@@ -25,7 +24,7 @@ func (fields *Fields) With(kvs ...interface{}) *Fields {
 		var ok bool
 		keys[i], ok = kvs[2*i].(string)
 		if !ok {
-			stdlog.Fatalf("invalid Fields.With call: non-string log field key: %v", kvs[2*i])
+			panic(fmt.Sprintf("invalid Fields.With call: non-string log field key: %v", kvs[2*i]))
 		}
 		values[i] = kvs[2*i+1]
 	}

fields_test.go

@@ -0,0 +1,41 @@
+package spcontext
+
+import (
+	"testing"
+
+	"github.com/franela/goblin"
+	"github.com/onsi/gomega"
+)
+
+func TestFieldsWith(t *testing.T) {
+	g := goblin.Goblin(t)
+	gomega.RegisterFailHandler(func(m string, _ ...int) { g.Fail(m) })
+
+	g.Describe("Happy path", func() {
+		f := &Fields{}
+		newFields := f.With("test", 1, "test2", 2)
+		g.It("empty base fields", func() {
+			gomega.Expect(f.EvaluateFields()).To(gomega.Equal([]any(nil)))
+		})
+		g.It("non empty new fields", func() {
+			gomega.Expect(newFields.EvaluateFields()).To(gomega.Equal([]any{"test", 1, "test2", 2}))
+		})
+	})
+	g.Describe("odd number of fields", func() {
+		f := &Fields{}
+		g.It("odd number of fields", func() {
+			gomega.Expect(func() {
+				f.With("test", 1, "test2") //nolint:staticcheck // negative test case
+			}).To(gomega.PanicWith("invalid Fields.With call: odd number of arguments"))
+		})
+	})
+	g.Describe("key is not string", func() {
+		f := &Fields{}
+		g.It("odd number of fields", func() {
+			gomega.Expect(func() {
+				f.With("test", 1, 3, 2)
+			}).To(gomega.PanicWith("invalid Fields.With call: non-string log field key: 3"))
+		})
+	})
+
+}