Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build Grating Wheel Sensor Telemetry Monitor #825

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

tnking97
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 14, 2021

Hello @tnking97, Thank you for updating !

Line 27:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file
Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file
Line 32:1: E402 module level import not at top of file
Line 33:1: E402 module level import not at top of file
Line 34:1: E402 module level import not at top of file
Line 80:85: E712 comparison to True should be 'if cond is True:' or 'if cond:'

Line 369:21: E126 continuation line over-indented for hanging indent

Line 60:1: E402 module level import not at top of file
Line 69:1: E402 module level import not at top of file
Line 70:1: E402 module level import not at top of file
Line 363:41: E128 continuation line under-indented for visual indent
Line 914:13: E125 continuation line with same indent as next logical line
Line 915:17: E117 over-indented
Line 1169:9: E722 do not use bare 'except'
Line 1257:21: E128 continuation line under-indented for visual indent

Line 114:55: E711 comparison to None should be 'if cond is not None:'

Comment last updated at 2021-12-09 20:53:47 UTC

@tnking97 tnking97 linked an issue Oct 14, 2021 that may be closed by this pull request
9 tasks
@tnking97 tnking97 self-assigned this Oct 14, 2021
@bourque bourque self-requested a review December 9, 2021 18:50
Copy link
Collaborator

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnking97 I just did an initial review of this and it looks really good! All of the major pieces are there. It is well organized, documented, and tested, and I don't see any major changes that need to be made. Excellent work!

docs/source/common_monitors.rst Show resolved Hide resolved
jwql/website/apps/jwql/data_containers.py Show resolved Hide resolved
jwql/tests/test_grating_monitor.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Grating Wheel Sensor Telemetry Monitor
3 participants