Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scikit image update from 0.21 to 0.23+ #2049

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

shachafl
Copy link
Collaborator

@shachafl shachafl commented Jan 4, 2025

This closes #2026
Updating to versions 0.22-0.24 caused mypy testing errors and warnings regarding future depreciation.
This was also an opportunity to remove stale code (when starfish was developed alongside scikit-image match_histograms()).
This PR includes:

  1. changed importing of img_as_float32() to skimage.util
  2. silencing mypy error due to dynamic function call
  3. removing stale code and loading match_histograms from skimage.exposure
  4. output parameter in gaussian() is replaced by out
  5. replacing _GeometricTransform with SimilarityTransform
  6. updating requirements files

@shachafl shachafl requested a review from berl January 4, 2025 20:47
Copy link
Collaborator

@berl berl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! @shachafl getting starfish up to date!

@berl berl merged commit 5f29505 into spacetx:master Jan 7, 2025
29 checks passed
@shachafl shachafl deleted the scikit-image-update branch January 8, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update scikit-image version (to >0.21) in REQUIREMENTS.txt file
2 participants