refactor/css agenda & chat + fix/minor css issues #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lunikai
changed the title
lunikai
changed the title
Sanghou
reviewed
May 29, 2024
Comment on lines
20
to
21
| * @deprecated use AgendaCard.Group instead | ||
| */ |
There was a problem hiding this comment.
이거 호환이 안 맞다고 해주셔서, 그 부분 코멘트 호환 안 맞다고 작성해주시거나 이슈로 생성되면 좋을 것 같아요!
현재 상황 : deprecated. 다만 대체할 컴포넌트가 없음
Sanghou
reviewed
May 29, 2024
Comment on lines
+76
to
+78
| <div css={[padding.vertical(7), center]}> | ||
| <DownArrowIcon /> | ||
| </Box> | ||
| </BorderedBox> | ||
| </Box> | ||
| <Box dir="row" w={130} h={28} gap={8} align="center"> | ||
| <Text variant="body" color="black"> | ||
| 투표 상세 | ||
| </Text> | ||
| <BorderedBox | ||
| borderColor="gray200" | ||
| bg="white" | ||
| w={75} | ||
| h={28} | ||
| align="center" | ||
| justify="space-between" | ||
| borderSize={1} | ||
| padHorizontal={12} | ||
| padVertical={7} | ||
| round={5} | ||
| borderStyle="solid" | ||
| dir="row" | ||
| </div> |
There was a problem hiding this comment.
혹시 여기 변경부분에 대해서 전후 비교를 알 수 있을까요?
기존 스타일이 안 맞아서 center가 변경된건지, 아니면 box -> div 변경하면서 필요해진 건지 궁금해서요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
Closes #336
also closes #411
also: agenda choice의 border color을 피그마와 같게 바꾸었습니다.
스크린샷
이후 Task *