Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Commit

Permalink
Remove AuthoritativeEntityResolver (#1453)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jamie Brynes authored Aug 14, 2020
1 parent cf3a0e9 commit 772a2bf
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 42 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- The GDK now depends on .NET Core v3.1.3xx instead of v2.2.2xx. [#1443](https://github.com/spatialos/gdk-for-unity/pull/1443)
- Removed APIs for AuthorityLossImminent. [#1451](https://github.com/spatialos/gdk-for-unity/pull/1451)
- All authority changes to `AuthorityLossImminent` will now be dropped, and callbacks will no longer trigger.
- Removed the `AuthoritativeEntityResolver`. The implementation was fundamentally flawed. [#1453](https://github.com/spatialos/gdk-for-unity/pull/1453)

### Added

Expand Down
20 changes: 18 additions & 2 deletions UPGRADE_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,26 @@ The `Reader` and `Writer` classes have had their `public Authority Authority` pr

### .NET Core Update

The GDK, in particular the code generator and deployment launcher, has been updated to use [.NET Core SDK v3.1.3xx](https://dotnet.microsoft.com/download/dotnet-core/3.1).
The GDK, in particular the code generator and deployment launcher, has been updated to use [.NET Core SDK v3.1.3xx](https://dotnet.microsoft.com/download/dotnet-core/3.1).

To update, download and install the new version from the link provided above.

### `AuthoritativeEntityResolver` removal

We removed the `AuthoritativeEntityResolver` as the implementation was fundamentally flawed. Depending on how you were using it, there are different replacements:

#### For your player entity

Use the `OwningWorkerEntityResolver` which uses the `OwningWorker` component from the Player Lifecycle Feature Module. Make sure that when you create your player's `EntityTemplate` you add the relevant components with:

```csharp
PlayerLifecycleHelper.AddPlayerLifecycleComponents(EntityTemplate template, clientWorkerId, serverAccess);
```

#### For server authoritative entities

If you were using this resolver on the server, we recommend merging the two Prefabs into one and rely on the GDK enabling/disabling behaviours when they are active or not.

## From `0.3.7` to `0.3.8`

### Asset based entity representation
Expand Down Expand Up @@ -69,7 +85,7 @@ The Scripting Backend defined in the Unity Project Settings is now overwritten b

In [#1376](https://github.com/spatialos/gdk-for-unity/pull/1376), some generated code has changed locations in your project. If you are ignoring these files in your `.gitignore`, you will want to add two new entries:

Before:
Before:

```
Assets/Generated/Source.meta
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit 772a2bf

Please sign in to comment.