Refactor registerTenantFinder method to reduce complexity #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've refactored the registerTenantFinder method to improve readability and reduce complexity.
Changes Made:
Extracted the configuration lookup into a variable $tenantFinderConfig.
Improved code readability and maintainability by reducing repeated calls to config.
Benefits:
Reduced Complexity: By storing the configuration value in a variable, we avoid making multiple calls to the config method, making the code cleaner and more efficient.
Improved Readability: The refactored method is easier to read and understand at a glance.
I believe these changes will help maintain the codebase more effectively and look forward to your feedback.
Best regards,
Ehsan Mahmoodi