Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor registerTenantFinder method to reduce complexity #536

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

misaf
Copy link
Contributor

@misaf misaf commented May 23, 2024

Hello,

I've refactored the registerTenantFinder method to improve readability and reduce complexity.

Changes Made:
Extracted the configuration lookup into a variable $tenantFinderConfig.
Improved code readability and maintainability by reducing repeated calls to config.

Benefits:
Reduced Complexity: By storing the configuration value in a variable, we avoid making multiple calls to the config method, making the code cleaner and more efficient.
Improved Readability: The refactored method is easier to read and understand at a glance.
I believe these changes will help maintain the codebase more effectively and look forward to your feedback.

Best regards,
Ehsan Mahmoodi

@masterix21 masterix21 merged commit 593df73 into spatie:main Jun 13, 2024
4 checks passed
@masterix21
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants