Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused compiler and javadoc options #276

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dwalluck
Copy link
Contributor

@dwalluck dwalluck commented Jan 22, 2025

The optimize tag is deprecated and a noop, and javadoc.opts is not set anywhere.

@dwalluck dwalluck force-pushed the pom-remove-unused-options branch from 0906759 to 5662538 Compare January 22, 2025 21:19
@dwalluck
Copy link
Contributor Author

The previous version of this pull request actually removed too much (the entire execution as opposed to just the configuration).

@bact bact self-requested a review January 22, 2025 21:24
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall merged commit 9b1ff24 into spdx:master Jan 22, 2025
1 check passed
@dwalluck dwalluck deleted the pom-remove-unused-options branch January 22, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants