-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elements array to the example for SpdxPackage and SBOM #1054
Conversation
Per the discussion on the tech call, there was consensus that elements should have a minimum of 1 for both SpdxPackage and SBOM. Fixes #1013 Signed-off-by: Gary O'Neall <[email protected]>
@JPEWdev - Please review |
If this is the correct specification, wouldn't it also be necessary to change
Also, I think we need to discuss whether Bom and SpdxDocument classes should have at least one element, rootElement. In the end, the discussion will be whether element, rootElement in ElementCollection class should be minCount == 1. |
Thanks for providing the syntax for adding this - I created an issue in the model repo to add the restrictions, but I didn't have the information on how to modify the markdown files. See spdx/spdx-3-model#841
For |
Please see my comment. This was triggered by SPDX Lite by @NorioKobota , which I am now updating to take into effect this new change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns with decision in the model.
Per the discussion on the tech call, there was consensus that elements should have a minimum of 1 for both SpdxPackage and SBOM.
Fixes #1013