Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Python 3.12 to avoid htmlmin issue with 3.13; update other dependencies #1133

Merged
merged 13 commits into from
Oct 13, 2024
Merged

Use Python 3.12 to avoid htmlmin issue with 3.13; update other dependencies #1133

merged 13 commits into from
Oct 13, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Oct 7, 2024 •
edited
Loading

  • Pin Python version to 3.12 as the latest Python version (3.13) will break our publishing and PR validation workflows.
  • Also update dependencies:
    • check-jsonschema == 0.29.4
    • pyshacl == 0.27.0
    • actions/checkout == v4.2.1

@bact
Update GitHub Actions checkout and check-jsonschema
b5f59a9 
check-jsonschema==0.29.3
actions/checkout==v4.2.0

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added ci Dev workflow and repo management dependencies Pull requests that update a dependency file labels Oct 7, 2024
@bact bact requested review from licquia and maxhbr October 7, 2024 10:54
@bact
Update checkout action to v4.2.1
f6ad08f 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
goneall approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bact
Copy link
Collaborator Author

bact commented Oct 12, 2024 •
edited
Loading

@goneall I have updated the Python version in .github/workflows/validate_pull_request.yml

  • was using container: python:3
  • now using the Python version that comes with ubuntu-latest

Python 3.13 released on 7 Oct 2024 and module cgi is no longer available - so the workflow breaks.
That module is required by one of the dependencies.

May need to specify the Python version (major.minor) in every workflows to 3.12.

bact added 6 commits October 12, 2024 15:40
@bact
Set Python to 3.12
b9bfc61 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Use Python 3.12
10628ca 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Try Python 3.12 with publish_v3 and validate_examples
832f591 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Move typo to another PR
cd595f0 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Revert changes in example
bf4c525 
Was set to see how validate_examples will run
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Minimize changeset
486a691 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested a review from goneall October 12, 2024 09:34
@bact bact changed the title Update GitHub Actions checkout and check-jsonschema Use Python 3.12 to avoid htmlmin issue with 3.13; update other dependencies Oct 12, 2024
@bact bact requested review from zvr and kestewart October 12, 2024 09:36
@bact
Copy link
Collaborator Author

bact commented Oct 12, 2024

@licquia @zvr @goneall @kestewart The new Python 3.13 will break our publishing workflow, this has to be fixed. Please review.

@bact bact mentioned this pull request Oct 12, 2024
Merged
goneall
goneall approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@bact
Copy link
Collaborator Author

bact commented Oct 13, 2024

As there's a break in the workflow and it needs to be fixed, I will merge this with one approval.

@bact bact merged commit 83bb057 into spdx:development/v3.0.1 Oct 13, 2024
2 checks passed
@bact bact deleted the update-workflow-deps branch October 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneall goneall goneall approved these changes

@licquia licquia Awaiting requested review from licquia

@maxhbr maxhbr Awaiting requested review from maxhbr

@zvr zvr Awaiting requested review from zvr

@kestewart kestewart Awaiting requested review from kestewart

Assignees
No one assigned
Labels
ci Dev workflow and repo management dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify Python version to avoid 3.13 in workflows
2 participants
@bact @goneall