-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract routing API sorts routes. #1941
base: main
Are you sure you want to change the base?
Abstract routing API sorts routes. #1941
Conversation
add connexion pull: spec-first#1941
Just an FYI that I've confirmed this fixes routing bugs in connexion that exist today. For example, attempt to add these 2 routes:
In 3.1.0 Not sure if there's more needed in this PR to get it merged but we've had to fork connexion until it will be as LMK if I can help out with some test cases or whatever to get this rolling. CC: @RobbeSneyders |
@dkoston adding a test would be very much appreciated and will prevent us from accidentally breaking the behavior in the future. |
@RobbeSneyders is there any documentation on how to run the test suite? I added some tests but running the lines from .github/workflows/pipline.yml results in
|
@RobbeSneyders @jmcs LMK if you have some docs on how to run the test suite locally and I'll get these tests completed. Thanks! |
Fixes #1879.
Changes proposed in this pull request:
RoutingMiddleware
toAbstractRoutingAPI
Let me know if anything else needs adjustments.