Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tests for p2p ready #702

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Refactor and add tests for p2p ready #702

merged 1 commit into from
Jan 17, 2025

Conversation

phillebaba
Copy link
Member

@phillebaba phillebaba commented Jan 17, 2025

Fixes issues with ready check to report ready when only bootstrap node is self and tests the ready function.

@phillebaba phillebaba force-pushed the test/p2p-ready branch 3 times, most recently from e672157 to 8d0006b Compare January 17, 2025 12:08
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/routing/bootstrap.go 66.66% 4 Missing ⚠️
pkg/routing/p2p.go 78.57% 2 Missing and 1 partial ⚠️
main.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
main.go 0.00% <0.00%> (ø)
pkg/routing/p2p.go 53.06% <78.57%> (+19.11%) ⬆️
pkg/routing/bootstrap.go 55.48% <66.66%> (+0.81%) ⬆️

@phillebaba phillebaba merged commit 3c85d7e into main Jan 17, 2025
9 checks passed
@phillebaba phillebaba deleted the test/p2p-ready branch January 17, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant