Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multi currencies support #1362

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove multi currencies support #1362

wants to merge 2 commits into from

Conversation

almet
Copy link
Member

@almet almet commented Dec 26, 2024

For more information about the rationale, this was discussed in our bugtracker.

Actually, this also removes the notion of currency, and I'm not sure it should go away, as it might be beneficial to keep it in order to display the currency of the project (to add a € or $ sign, for instance)

@almet almet marked this pull request as draft December 26, 2024 23:27
@almet almet force-pushed the remove-currencies branch 2 times, most recently from 2bb1e61 to 6bf041a Compare December 28, 2024 01:13
For more information about the rationale, this was [discussed](#1232 (comment)) in our bugtracker.
@almet almet force-pushed the remove-currencies branch from 6bf041a to 8791cc8 Compare December 28, 2024 01:17
@Glandos
Copy link
Member

Glandos commented Jan 3, 2025

I don't think removing support for it is a good idea. I much prefer having a manual rate forms, where the project admin must enter all rates from currently used currencies.

@almet
Copy link
Member Author

almet commented Jan 3, 2025

I don't think removing support for it is a good idea. I much prefer having a manual rate forms, where the project admin must enter all rates from currently used currencies.

Thanks for your input, but I fear it's coming a bit late. As you can see in #1232 (comment) we discussed it this summer and decided to remove support unless somebody would like to contribute such a change, as nobody on the maintainer team wants to do it.

It seems counter-intuitive to remove a feature, but I really believe it's the direction we should take, unless somebody wants to weight in and do it.

@almet
Copy link
Member Author

almet commented Jan 3, 2025

unless somebody wants to weight in and do it.

And actually, I believe it might be too late for this as well, since we've been waiting for 6 months already.

@Glandos
Copy link
Member

Glandos commented Jan 3, 2025

Yes, I know. I'm just sad, but I don't have enough time to work on this :(

@almet
Copy link
Member Author

almet commented Jan 3, 2025

Yes, I know. I'm just sad, but I don't have enough time to work on this :(

I agree with you :-) The goal is to reduce the maintenance burder as much as possible, and if somebody wants to add the feature back, it'll be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants