fix: await reconciliation bug #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
requested review from
fabriziodemaria,
nickybondarenko and
vahidlazio
as code owners
nicklasl
commented
Nov 29, 2024
| suspend fun awaitReconciliation(timeoutMillis: Long = 5000) { | ||
| if (timeoutMillis <= 0) error("timeoutMillis need to be larger than 0") | ||
| debugLogger?.logMessage("reconciliation started") | ||
| yield() // will make sure that we respect other coroutine scopes triggered before this |
There was a problem hiding this comment.
This line is the actual fix. The rest is mainly just improvements.
nickybondarenko
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a case for race conditions that could occur when calling putContext() followed by a awaitReconciliation() where the contextChanges updates did not trigger a fetchAndActivate before awaitReconciliation had finished.
Replaces #185