Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom note locator #234

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

Kamyki
Copy link
Contributor

@Kamyki Kamyki commented Nov 13, 2023

HI!
I found myself in need of customising ketama behaviour. From my expriences with spymemcache, number of vnodes sometimes needs fine-tuning. I also found existing issue #40 so I hope it will help others.

EDIT: better description

This pull request introduces:

  • abstraction upon Conintuum class. NodeLocator interface which allows customisation of mapping of keys into memcache servers.
  • builder parameter for node locator.
  • simple test of custom node locator with prefix logic.

@Kamyki
Copy link
Contributor Author

Kamyki commented Dec 4, 2023

Hi maintainers,

I'm writing to bump this pull request. I have updated formatting errors pointed by last unsuccessful build. I haven't heard back from anyone yet, so I wanted to check in and see if there is anything I can do to help with the review process.

Thanks,
Kamil

Add parameter to builder class with default for existing NodeLocator (Continuum).
Add ability to change vnode_ratio in Continuum.
@Kamyki Kamyki force-pushed the add-custom-note-locator branch from 983e83b to 10b8af2 Compare December 6, 2023 13:43
@Kamyki
Copy link
Contributor Author

Kamyki commented Feb 2, 2024

Hi maintainers,
bumping PR. We are currently maintaining fork with this functionality and using it with our services, but I would gladly help with integrating it to main branch so more people can benefit from it. Just let me know what needs to be done.

@thiagocesarj thiagocesarj merged commit 08d7d95 into spotify:master Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants