Switch from abstract val to def in traits #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Jul 10, 2023
| protected def isEmpty(v: T): Boolean | ||
| def write(c: RecordConsumer, v: T)(cm: CaseMapper): Unit | ||
| def newConverter: TypeConverter[T] | ||
| def newConverter(): TypeConverter[T] |
There was a problem hiding this comment.
This function has a side effect and should hence be defined with parenthesis
RustedBones
force-pushed
the
avoid-val-traits
branch
from
7e5f32f to
8054da3
Compare
kellen
approved these changes
Nov 6, 2023
| @@ -133,7 +133,7 @@ object ProtobufField { | |||
| new ProtobufField[T] { | |||
| override type FromT = tc.FromT | |||
| override type ToT = tc.ToT | |||
| override val hasOptional: Boolean = tc.hasOptional | |||
| override def hasOptional: Boolean = tc.hasOptional | |||
There was a problem hiding this comment.
In these implementation cases, isn't it preferable to define these fields as val (or maybe lazy val?)
There was a problem hiding this comment.
the only case where there is some computation is in Record where it is already a val. IMHO here it is not worth caching another constant
RustedBones
force-pushed
the
avoid-val-traits
branch
from
e05f535 to
7d1b796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer using
defover abstractvalin traits.This increases implementation flexibility and avoid unnecessary serialization and memory usage (when referring to a constant for instance)