Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/GH-314 ingest #317

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Feature/GH-314 ingest #317

wants to merge 13 commits into from

Conversation

arov00
Copy link
Contributor

@arov00 arov00 commented Jan 22, 2025

closes #314

@arov00 arov00 requested a review from a team as a code owner January 22, 2025 16:37
@arov00 arov00 changed the title Feature/gh 314 ingest Feature/GH-314 ingest Jan 22, 2025
@arov00
Copy link
Contributor Author

arov00 commented Jan 22, 2025

Looks like the build is failing because we are affected by this issue: duckdb/duckdb-java#14

A fix is scheduled to be released in a couple of days, so this can wait.

gaetancollaud
gaetancollaud reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@gaetancollaud gaetancollaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Where are the data stored ? Can we configure it somehow ? So we know what volume to configure

aggregator/src/main/java/io/spoud/kcc/aggregator/olap/DataExportResource.java Outdated Show resolved Hide resolved
aggregator/src/main/java/io/spoud/kcc/aggregator/olap/AggregatedMetricsRepository.java Outdated Show resolved Hide resolved
aggregator/src/main/java/io/spoud/kcc/aggregator/olap/AggregatedMetricsRepository.java Outdated Show resolved Hide resolved
aggregator/src/main/java/io/spoud/kcc/aggregator/olap/AggregatedMetricsRepository.java Outdated Show resolved Hide resolved
aggregator/src/test/java/io/spoud/kcc/aggregator/olap/AggregatedMetricsRepositoryTest.java Outdated Show resolved Hide resolved
@arov00
Copy link
Contributor Author

arov00 commented Jan 22, 2025

Thanks for the PR.

Where are the data stored ? Can we configure it somehow ? So we know what volume to configure

Thanks for reviewing! Yes storage for the data can be configured via the cc.olap.database.url parameter. I have added a docstring with more information here.

gaetancollaud
gaetancollaud approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@gaetancollaud gaetancollaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double check for sql injections.

aggregator/src/main/java/io/spoud/kcc/aggregator/olap/AggregatedMetricsRepository.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetancollaud gaetancollaud gaetancollaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load data into an integrated OLAP database. Allow downloading a CSV or JSONL data export via API endpoint
2 participants
@arov00 @gaetancollaud