Feature/helm improvements #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,7 @@ | |||
| {{- end -}} | |||
| {{ $rawMetricsTopics := (include "rawMetricsTopics" .) }} | |||
|
|
|||
| {{ if .Values.aggregator.enabled -}} | |||
There was a problem hiding this comment.
what the use case of disabling the aggregator ?
There was a problem hiding this comment.
This is to support the use-case where we scrape data from multiple clusters. In this case, we would spin up a telegraf for each cluster, but then use a single aggregator that consumes from the individual raw metrics topics.
This use case is not 100% supported yet, because for this to work, we would also need to be able to configure each telegraf to produce to a Kafka cluster that is different from the one that is being scraped. This is something that can/should be added in a future PR.
gaetancollaud
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.