-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Spree 2.4 support #107
Conversation
…s, add icons/remove words from links and add spinner on product bundle area of line_item edit, remove duplicate gemspec reference to wombat
We just started looking into doing the same update for a project ourselves, and started looking at the test failure that came up on Travis around checkout_spec.rb:44 (we're getting the same failure locally). It's confusing, because the screens leading up to the assertion all list the variant's SKU (in this case "SKU-2") but the SKU displayed on This makes me wonder if checkout_spec.rb:48 was intended to read as Let me know if you'd rather I just open a separate issue for this. |
Weird. I just ran the tests with the same version of Ruby (2.0.0-p598) that failed for Travis CI and all tests passed. |
thanks a lot @smartacus! I wanted to take a look at this myself, looking forward to take a closer look at the PR |
thanks @smartacus, closed some of those I'm not sure I understand the availability problem yet, need more time to look into it. Either way this does seem to run smooth on spree 2.4 now thanks a lot |
This adds Spree 2.4 support to spree-product-assembly.