Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Spree 2.4 support #107

Merged
merged 11 commits into from Feb 22, 2015
Merged

Added Spree 2.4 support #107

merged 11 commits into from Feb 22, 2015

Conversation

smartacus
Copy link

This adds Spree 2.4 support to spree-product-assembly.

@anthonynavarre
Copy link

We just started looking into doing the same update for a project ourselves, and started looking at the test failure that came up on Travis around checkout_spec.rb:44 (we're getting the same failure locally).

It's confusing, because the screens leading up to the assertion all list the variant's SKU (in this case "SKU-2") but the SKU displayed on admin_orders_path shows up as the product's master variant ("SKU-1").

This makes me wonder if checkout_spec.rb:48 was intended to read as page.should have_content(variant.sku) instead of page.should have_content(variant.product.name) — in either case, it's hard to tell whether the test, implementation or both are wrong.

Let me know if you'd rather I just open a separate issue for this.

@dfreerksen
Copy link

Weird. I just ran the tests with the same version of Ruby (2.0.0-p598) that failed for Travis CI and all tests passed.

@huoxito
Copy link

huoxito commented Feb 18, 2015

thanks a lot @smartacus! I wanted to take a look at this myself, looking forward to take a closer look at the PR

huoxito added a commit that referenced this pull request Feb 22, 2015
@huoxito huoxito merged commit 9934107 into spree-contrib:master Feb 22, 2015
@smartacus
Copy link
Author

Thank you for merging this @huoxito. By the way, I believe this PR resolves the following...

Pull Requests: #103, #106
Issues: #100, #101, #102, #105 (and possibly #99)

@huoxito
Copy link

huoxito commented Feb 23, 2015

thanks @smartacus, closed some of those I'm not sure I understand the availability problem yet, need more time to look into it. Either way this does seem to run smooth on spree 2.4 now thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants