Memory allocations #184
Open
Memory allocations #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Freezing empty string * use `compact!` instead of compact
aldesantis
requested changes
Jul 31, 2020
| @@ -196,7 +196,7 @@ def digest | |||
| # | |||
| def self.digest(details) | |||
| overrides = self.find(details) | |||
| to_hash = overrides.inject('') { |digest, override| digest << override.digest } | |||
| to_hash = overrides.inject(''.freeze) { |digest, override| digest << override.digest } | |||
There was a problem hiding this comment.
This needs to become a +=.
There was a problem hiding this comment.
Do you mean overrides.inject('') { |digest, override| digest += override.digest } ?
Uhm maybe also overrides.map(&:digest).join?
There was a problem hiding this comment.
@ProGM I mean:
overrides.inject(''.freeze) { |digest, override| digest += override.digest }<< will fail on a frozen string because it attempts to mutate the object, so you need to create a new string every time. I'm not sure if that will negate the performance benefits of using .freeze though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a peak of memory allocations in this file by using
derailedgemThat could be simply fixed using a
.freeze.compact!instead of compact