GH-117: Fix auto-wire ambiguity in the FileSupplierConfiguration

Fixes: #117 * Use `fileReadingMessageSource` bean name as it is expected by the injection point. * Fix `DefaultFileSupplierTests` for a new `fileReadingMessageSource` bean name
spring-cloud · Dec 19, 2024 · 9bc93a9 · 9bc93a9
1 parent 4024f19
commit 9bc93a9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...r/src/main/java/org/springframework/cloud/fn/supplier/file/FileSupplierConfiguration.java b/...r/src/main/java/org/springframework/cloud/fn/supplier/file/FileSupplierConfiguration.java
@@ -67,8 +67,6 @@ public class FileSupplierConfiguration {
 	public Publisher<Message<String>> fileTailingFlow(FileSupplierProperties fileSupplierProperties) {
 		FileSupplierProperties.Tailer tail = fileSupplierProperties.getTailer();
 		TailAdapterSpec tailAdapterSpec = Files.tailAdapter(fileSupplierProperties.getTail())
-			// TODO until Spring Integration 6.2.3
-			.autoStartup(false)
 			.fileDelay(tail.getAttemptsDelay().toMillis())
 			// OS native tail command
 			.nativeOptions(tail.getNativeOptions())
@@ -123,7 +121,7 @@ protected static class FileMessageSourceConfiguration {
 		}
 
 		@Bean
-		public ChainFileListFilter<File> filter(ConcurrentMetadataStore metadataStore) {
+		public ChainFileListFilter<File> fileListFilter(ConcurrentMetadataStore metadataStore) {
 			ChainFileListFilter<File> chainFilter = new ChainFileListFilter<>();
 			if (StringUtils.hasText(this.fileSupplierProperties.getFilenamePattern())) {
 				chainFilter
@@ -141,7 +139,7 @@ else if (this.fileSupplierProperties.getFilenameRegex() != null) {
 			return chainFilter;
 		}
 
-		@Bean
+		@Bean("fileReadingMessageSource")
 		public FileInboundChannelAdapterSpec fileMessageSource(FileListFilter<File> fileListFilter,
 				@Nullable ComponentCustomizer<FileInboundChannelAdapterSpec> fileInboundChannelAdapterSpecCustomizer) {
 

diff --git a/...er/src/test/java/org/springframework/cloud/fn/supplier/file/DefaultFileSupplierTests.java b/...er/src/test/java/org/springframework/cloud/fn/supplier/file/DefaultFileSupplierTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2020-2022 the original author or authors.
+ * Copyright 2020-2024 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -47,7 +47,7 @@
 public class DefaultFileSupplierTests extends AbstractFileSupplierTests {
 
 	@Autowired
-	@Qualifier("fileMessageSource")
+	@Qualifier("fileReadingMessageSource")
 	private FileReadingMessageSource fileMessageSource;
 
 	@Autowired