Update to Spring Boot 3.3.0-M1 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the spring-boot-dependencies version to `3.3.0-M1`. This update also transitively updates the AssertJ core library to version `3.25.1` which introduces a deprecation for `AbstractAssert#toList`. As such, these deprecated usages are replaced in several tests with `AbstractAssert#asInstanceOf`. Resolves spring-cloud#10
onobc
commented
Feb 4, 2024
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2020-2022 the original author or authors. | |||
| * Copyright 2020-2024 the original author or authors. | |||
There was a problem hiding this comment.
What a nice little touch this is - thank you @artembilan
onobc
commented
Feb 4, 2024
| .hasSize(1) | ||
| .element(0) | ||
| .isEqualTo("foo")) | ||
| .asInstanceOf(InstanceOfAssertFactories.LIST) |
There was a problem hiding this comment.
[PR_GLOBAL_COMMENT]
As the PR comment describes, the asList is deprecated w/ suggested replacement asInstanceOf. I additionally simplified the usages as follows:
hasSize + element + isEqualTo->containsExactlyhasSize + contains->containsExactlyInAnyOrderinInstanceOf + asList->asInstanceOf(IOAF.LIST)(it checks instancef implicitly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the spring-boot-dependencies version to
3.3.0-M1.This update also transitively updates the AssertJ core library to version
3.25.1which introduces a deprecation forAbstractAssert#toList. As such, these deprecated usages are replaced in several tests withAbstractAssert#asInstanceOf.Resolves #10