Improve IsoFormattingDateDataFormatter #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit all date related fields were formatted as an ISO_LOCAL_DATE_TIME. With this commit we inspect the type it actually is date, time or datetime and use the proper ISO_LOCAL formatting for that. Another improvement is to use the cached result for the formula instead of re-evaluating the formula and use that type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit all date related fields were formatted as an ISO_LOCAL_DATE_TIME.
With this commit we inspect the type it actually is date, time or datetime and use the proper ISO_LOCAL formatting for that.
Another improvement is to use the cached result for the formula instead of re-evaluating the formula and use that type.