Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed assertion in DefaultGenerateOneTimeTokenRequestResolver #16507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed assertion in DefaultGenerateOneTimeTokenRequestResolver #16507

wants to merge 1 commit into from

Conversation

franticticktick
Copy link
Contributor

Fixed assertion in DefaultGenerateOneTimeTokenRequestResolver.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 30, 2025
Tejas-Teju
Tejas-Teju reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Tejas-Teju Tejas-Teju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me @franticticktick

Any thoughts on the commit message?
Message: Fix setExpiresIn assertion in DefaultGenerateOneTimeTokenRequestResolver

Refer Commit Guidelines

@franticticktick
Copy link
Contributor Author

franticticktick commented Jan 31, 2025 •
edited
Loading

Changes looks good to me @franticticktick

Thank you so much, I'm happy that you liked it :)

Please read carefully the guideline that you sent here:

Format commit messages using 55 characters for the subject line, 72 characters per line for the description, followed by the issue fixed, for example, Closes gh-22276.

Your solution fits the description rather, but not the commit message. This PR has a little polish, it does not need to be tracked or described in detail. I recommend that you look at other commits in spring security to see how polishing is done. The commit message fully reflects the essence of the polish, and if it is confusing, then one of the maintainers will definitely note it in the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tejas-Teju Tejas-Teju Tejas-Teju left review comments

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franticticktick @Tejas-Teju @spring-projects-issues