-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve interoperability issues. #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top notch!
Why the move to singular detail in types? They contain multiple things (e.g. claims) and the specs use plural? (although some of them e.g. only contain a single credential definition so it makes sense)
} | ||
} | ||
} | ||
#[serde(untagged)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spicy (I'm just kidding, I don't think there's a good solution here, there's a tradeoff between ease of use/debugging and extensibility, if only there was a good way of getting good error messages with untagged enums...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's a good point. We could maybe write a Deserialize wrapper that includes the format
in the error response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then you would have to do a match on the format or deserialize one by one? I don't know that we can really improve the situation, it is what it is
I wanted to make a distinction between: The spec uses "authorization details object" for one of those objects, so could go for that instead if that's clearer? |
I like that, but I don't have a strong opinion |
format
orcredential_identifier
.