Fix various performance issues #724
Open
+120
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e554c4c
commented
Jan 23, 2025
| pub struct Server(String); | ||
| #[serde(transparent)] | ||
| pub struct Server { | ||
| name: Arc<str>, |
There was a problem hiding this comment.
I would prefer to change this to a named struct instead of a tuple struct, since future PRs will add fields here.
andymandias
reviewed
Jan 23, 2025
andymandias
reviewed
Jan 23, 2025
This commit includes various fixes that I have found working on bouncer-networks. It includes several performance benefits—such as changing `Server` to be an `Arc<str>` which removes much of the copying overhead. I have also made sure that there is only one copy of the server config in the `Halloy` struct, which was previously duplicated for seemingly no reason. Still, several performance issues go un-addressed. such as the duplication of server configs between threads (should this also be an `Arc<config>`?) and the copying of `client` structs. I have also made some changes to the client. The capability negotiation process has been streamlined, and I've eliminated some branching with preference toward pattern matching. I've also fixed a slight error with halloy, making sure that it detects the end of registration correctly (matching other clients). I have also made changes to the `Cargo.toml` in the `data` crate. This is to fix some compilation issues when building that crate in isolation. I would like this fixed so that it'd be easier to run `data` crate tests in isolation. Ideally I think that each of the sub-crates should be tested individually in CI—but that's out of scope for this PR. In my opinion, this resolves squidowl#640
Draft
andymandias
reviewed
Jan 24, 2025
| } | ||
| if newly_contains("extended-monitor") { | ||
| requested.push("extended-monitor"); | ||
| } | ||
| if contains("account-notify") || newly_contains("account-notify") { | ||
| if newly_contains("account-notify") { |
There was a problem hiding this comment.
I think we can skip this and condense the conditionals, similar to what you did above. Everything else looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes various fixes that I have found working on bouncer-networks. It includes several performance benefits—such as changing
Serverto be anArc<str>which removes much of the copying overhead. I have also made sure that there is only one copy of the server config in theHalloystruct, which was previously duplicated for seemingly no reason.Still, several performance issues go un-addressed. such as the duplication of server configs between threads (should this also be an
Arc<config>?) and the copying ofclientstructs.I have also made some changes to the client. The capability negotiation process has been streamlined, and I've eliminated some branching with preference toward pattern matching. I've also fixed a slight error with halloy, making sure that it detects the end of registration correctly (matching other clients).
I have also made changes to the
Cargo.tomlin thedatacrate. This is to fix some compilation issues when building that crate in isolation. I would like this fixed so that it'd be easier to rundatacrate tests in isolation.Ideally I think that each of the sub-crates should be tested individually in CI—but that's out of scope for this PR.
In my opinion, this resolves #640