Correctly record the time when a dataset is created and update the last_used time #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last_used time whenever the dataset is used in a transform. The create time had incorrectly been set to 0 and the last_used time set to the current date/time. We now correclty set the last_updated time to the current time along with last_used. Then any time the dataset is referenced, we update last_used.
ponyisi
reviewed
Jan 13, 2025
| @@ -54,7 +54,7 @@ def from_did(cls, did: DIDParser, logger: Logger, extras: dict[str, str] = None, | |||
| dataset = Dataset( | |||
| name=did.full_did, | |||
| last_used=datetime.now(tz=timezone.utc), | |||
| last_updated=datetime.fromtimestamp(0), | |||
| last_updated=datetime.now(tz=timezone.utc), | |||
There was a problem hiding this comment.
Would it be more consistent if last_updated were set to last_used when the dataset is first created (as opposed to being marginally later, as now)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The create time is incorrectly been set to 0 and the last_used time set to the current date/time. The last used time is never updated so it is useless.
Resolves #906
Approach
Set the last_updated and last_used fields to the current time when the dataset is created. Update the record to set last_used whenever a cached dataset is used in subsequent transforms