Allow items to have both time ranges point in time datetimes #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
order is important to avoid accidentally overwriting the datetime field
jisantuc
changed the title
jisantuc
commented
Sep 21, 2021
Comment on lines
+22
to
+23
| // order is important here! the time range encoder also writes a `null` value to the | ||
| // datetime field, which overwrites what the point-in-time encoder wants to write. |
There was a problem hiding this comment.
Would not have figured this out if it hadn't been for the round trip tests. ♥ CodecTests so much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR switches from a sum type to cats's
Iortype for encoding item datetimes.Checklist
chan)Helps with azavea/franklin#960