switch to derived NUMS #89
Conversation
|
|
|
@aldur will it be enough instead of writing derivation code here just put a comment with link to rust derivation code in sbtc repo. Like, if somebody don't trust us they can just see at rust code and even run it by themselves |
src/util/depositRequest.ts
Outdated
| @@ -16,6 +16,13 @@ export const NUMS_X_COORDINATE = new Uint8Array([ | |||
| 0xee, 0x9a, 0xce, 0x80, 0x3a, 0xc0, | |||
| ]); | |||
There was a problem hiding this comment.
Is this still used anywhere?
There was a problem hiding this comment.
I'm just waiting if we want add derivation code here as well, or just a comment with link to sbtc derivation code. If we pick second option this should be deleted
There was a problem hiding this comment.
I think it's OK to delete it
There was a problem hiding this comment.
@aldur, WDYT about this? I personally would like just to left a comment, extra code will add unnecessary complexety while if somebody wants to check if this key is really derived from NUMS they can just execute derivation code by themselves
There was a problem hiding this comment.
Yeah I did comment it's OK to delete it?
There was a problem hiding this comment.
Yep, I deleted it already in 1a928e3. Sorry for extra ping, probably my PR page didn't refreshed automatically and I forgot to do it manually
src/util/depositRequest.ts
Outdated
| export const DERIVED_NUMS_X_COORDINATE = new Uint8Array([ | ||
| 0x4a ,0x30 ,0xb2 ,0xe4 ,0x61 ,0xb2 ,0x80, 0xc0, | ||
| 0xb1, 0x3a, 0x03, 0x79, 0x90, 0x96, 0xab, 0x12, | ||
| 0x56, 0x58, 0x91, 0x53, 0xfc, 0x4b, 0x9c, 0x8c, | ||
| 0xea, 0xd1, 0x6d, 0xc0, 0xb6, 0x42, 0x06, 0x97, | ||
| ]); |
|
Note for ourselves: this will need to be merged after stacks-network/sbtc#1255 |
|
Closing this (since we can't switch to a derived pub-key for the signer aggregate key). |
Description
Currently we use NUMS internal key for taproot reclaim transactions. Unfortunately, Ledger don't allow users to sign trunsactions with not-deriven internal key, and Ledger users can't do reclaim. This PR switches from NUMS to key, derived from NUMS with path "0/0"
Checklist
npm run testpasses