Aperture native timeouts #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry to have missed this one @bucko13 ! I was travelling quite a bit this spring, but finally back in action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR now stable and close to being merged into the aperture repo, we can use that to provide LSAT expiration support from aperture baked LSATs. This simplifies the application by quite a bit and makes it easier to deploy a meme server that can be protected by an LSAT that can expire. This also means that the only caveats sphinx-meme has to care about are application specific (currently just file size limits as documented here).
This PR supersedes this one in sphinx-meme by using the new aperture docker image for aperture. It also replaces the sphinx meme image which is over 2 years old with a newer one that supports the new largefile endpoint (that is opt-in only). Ideally the official image can be updated and used here (the one referenced is just build and published from master).