Allow downstream macros #3779
Allow downstream macros #3779
Conversation
|
I'm out of the loop. @tarrencev are you able to declare these macros in Dojo via the mechanism that already exist in Scarb? |
Hmm I wasn't aware of a mechanism in scarb, do you mind sharing more? |
There was a problem hiding this comment.
I meant the CairoPluginRepository thingy that you use for the semantic plugin. Are you able to use InlineMacros via it or do you miss something on Scarb's side also here?
Reviewable status: 0 of 2 files reviewed, all discussions resolved
Oh yes we are using that but the core inline macro plugin is registered earlier in the pipeline and emits a diagnostic for any macro it doesn't understand. From what I can tell, it isn't possible to register our inline macro plugin before the core implementation? |
There was a problem hiding this comment.
Yeah, your understanding is correct and this PR is definitely needed :) I was really just asking for feedback if you are able to push your plugins to Scarb :)
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @tarrencev)
a discussion (no related file):
No longer relevant - was merged into dev-v2.1.0 and no longer relevant on main as well.
Similar to how we allow downstream derives for now
This change is