Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive hash on Call #4093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gaetbout
Copy link
Contributor

@gaetbout gaetbout commented Sep 19, 2023

For convenience Call should derive Hash


This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @gaetbout)


corelib/src/starknet/account.cairo line 7 at r1 (raw file):

    to: ContractAddress,
    selector: felt252,
    calldata: Array<felt252>

Hash on array is yet to be implemented (and requires decisions).
This will not work for the time being.

Code quote:

    calldata: Array<felt252>

@gaetbout
Copy link
Contributor Author

hey @orizi,
lmk if a decision is taken, I wouldn't mind doing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants