Added match_nullable_snapshot.

[orizi]

This change is 

[yuvalsw]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @orizi)

---

-- commits line 2 at r1:
Why is it needed?

---

corelib/src/nullable.cairo line 35 at r1 (raw file):

        nullable_from_box(BoxTrait::new(value))
    }
    fn is_null(self: @Nullable<T>) -> bool {

please also test is_null.

---

crates/cairo-lang-sierra-to-casm/src/invocations/nullable.rs line 27 at r1 (raw file):

        NullableConcreteLibfunc::MatchNullable(_)
        | NullableConcreteLibfunc::MatchNullableSnapshot(_) => {
            build_nullable_match_nullable(builder)

If it's the exact same casm, why do we need another libfunc?

---

tests/e2e_test_data/libfuncs/nullable line 121 at r1 (raw file):

//! > cairo
fn foo(x: @Nullable::<Array<felt252>>, y: Box::<@Array<felt252>>) -> Box::<@Array<felt252>> {

remove all "::"

Code quote:

able::<Array<felt252>>, y: Box::<@Array<felt252>>) -> Box::<@Array<felt252>>

[orizi]

Reviewable status: 6 of 9 files reviewed, 3 unresolved discussions (waiting on @yuvalsw)

---

-- commits line 2 at r1:

Previously, yuvalsw wrote…

Why is it needed?

specifically for the non-consuming is_null.

---

corelib/src/nullable.cairo line 35 at r1 (raw file):

Previously, yuvalsw wrote…

please also test is_null.

Done.

---

crates/cairo-lang-sierra-to-casm/src/invocations/nullable.rs line 27 at r1 (raw file):

Previously, yuvalsw wrote…

If it's the exact same casm, why do we need another libfunc?

it is a different signature - same code - as always with snapshots.

[yuvalsw]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/test/nullable_test.cairo line 8 at r2 (raw file):

    let nullable_x = NullableTrait::new(x);
    assert(!nullable_x.is_null(), 'nullable_x.is_null() true');
    assert_eq(@nullable_x.deref(), @x, 'x != 10');

x is 10 anyway, rephrase?

Code quote:

x != 10

---

corelib/src/test/nullable_test.cairo line 17 at r2 (raw file):

}

// Test objects of size>1.

rename the function accordingly?

Code quote:

// Test objects of size>1.

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yuvalsw)

---

corelib/src/test/nullable_test.cairo line 8 at r2 (raw file):

Previously, yuvalsw wrote…

x is 10 anyway, rephrase?

Done.

---

corelib/src/test/nullable_test.cairo line 17 at r2 (raw file):

Previously, yuvalsw wrote…

rename the function accordingly?

Done.

[yuvalsw]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/test/nullable_test.cairo line 17 at r3 (raw file):

}

// Testing `u256` as a tests for objects of size larger than 1.

Suggestion:

s a test fo

[orizi]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)