Contract segmentation: Add bytecode_segment_lengths to CasmContractClass.

[liorgold2]

Stack:

• Bump Sierra version to 1.5.0. #4516
• Contract segmentation: Add bytecode_segment_lengths to CasmContractClass. #4515 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @liorgold2)

---

crates/cairo-lang-starknet/src/contract_segmentation.rs line 16 at r1 (raw file):

#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(untagged)]
pub enum NestedIntList {

why not a vec of vecs?

---

crates/cairo-lang-starknet/src/contract_segmentation.rs line 22 at r1 (raw file):

#[derive(Error, Debug, Eq, PartialEq)]

Suggestion:

}

#[derive(Error, Debug, Eq, PartialEq)]

[liorgold2]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-starknet/src/contract_segmentation.rs line 16 at r1 (raw file):

Previously, orizi wrote…

why not a vec of vecs?

The OS supports any tree. In particular, I want to do some optimizations later. E.g., if a function has one segment then it will be a leaf instead of a node with one child. Same for small functions (as there is a non-negligible overhead in the handling of segments in the OS, compared to computing Poseidon)

[liorgold2]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-starknet/src/contract_segmentation.rs line 22 at r1 (raw file):

#[derive(Error, Debug, Eq, PartialEq)]

Done.

[orizi]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @liorgold2)

---

crates/cairo-lang-starknet/src/contract_segmentation.rs line 16 at r1 (raw file):

Previously, liorgold2 wrote…

The OS supports any tree. In particular, I want to do some optimizations later. E.g., if a function has one segment then it will be a leaf instead of a node with one child. Same for small functions (as there is a non-negligible overhead in the handling of segments in the OS, compared to computing Poseidon)

what i assumed - but please add some doc as to why.

[liorgold2]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-starknet/src/contract_segmentation.rs line 16 at r1 (raw file):

Previously, orizi wrote…

what i assumed - but please add some doc as to why.

Done.

[orizi]

Reviewed 2 of 3 files at r1, 1 of 1 files at r3.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @liorgold2)

[orizi]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)