Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: faster append_formatted_to_byte_array #5427

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: faster append_formatted_to_byte_array #5427

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7600afc
feat: faster append_formatted_to_byte_array
Th0rgal Apr 16, 2024
8025507
fix: formatted empty value is zero
fricoben Apr 16, 2024
466f9d9
feat: optimize recursion stop condition
Th0rgal Apr 17, 2024
24ae33c
docs: Describe what append_digits_util functions do
Th0rgal Apr 17, 2024
c18e62e
fix: remove inline to minimize bytecode
Th0rgal Apr 17, 2024
f6d051f
fix: formatting
ayushtom Apr 17, 2024
9ca5084
Merge branch 'main' into feat/faster_bytes_formatting
Th0rgal May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 31 additions & 26 deletions corelib/src/to_byte_array.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,39 +83,44 @@ fn append_formatted_to_byte_array<
let base: T = base_nz.into();
let base: u8 = base.try_into().unwrap();
assert(base > 1, 'base must be > 1');
assert(base <= 36, 'base must be <= 36');

let mut reversed_digits = array![];
if (*value).is_zero() {
byte_array.append_byte('0');
return;
};

if base <= 10 {
loop {
let (new_value, digit) = DivRem::div_rem(*value, base_nz);
value = @new_value;
let digit_as_u8: u8 = digit.try_into().unwrap();
reversed_digits.append(digit_as_u8 + '0');
if (*value).is_zero() {
break;
};
}
append_small_digits_util(value, ref byte_array, base_nz);
} else {
loop {
let (new_value, digit) = DivRem::div_rem(*value, base_nz);
value = @new_value;
let digit_as_u8: u8 = digit.try_into().unwrap();
reversed_digits.append(get_big_base_digit_representation(:digit_as_u8));
if (*value).is_zero() {
break;
};
};
assert(base <= 36, 'base must be <= 36');
append_big_digits_util(value, ref byte_array, base_nz);
}
}

let mut span = reversed_digits.span();
loop {
match span.pop_back() {
Option::Some(byte) => { byte_array.append_byte(*byte); },
Option::None => { break; },
};
#[inline]
fn append_small_digits_util<T, +Drop<T>, +Copy<T>, +DivRem<T>, +TryInto<T, u8>, +Zeroable<T>,>(
mut value: @T, ref byte_array: ByteArray, base_nz: NonZero<T>,
) {
if (*value).is_zero() {
return;
};
let (new_value, digit) = DivRem::div_rem(*value, base_nz);
let digit_as_u8: u8 = digit.try_into().unwrap();
append_big_digits_util(@new_value, ref byte_array, base_nz);
byte_array.append_byte(digit_as_u8 + '0');
}

#[inline]
fn append_big_digits_util<T, +Drop<T>, +Copy<T>, +DivRem<T>, +TryInto<T, u8>, +Zeroable<T>,>(
mut value: @T, ref byte_array: ByteArray, base_nz: NonZero<T>,
) {
if (*value).is_zero() {
return;
};
let (new_value, digit) = DivRem::div_rem(*value, base_nz);
let digit_as_u8: u8 = digit.try_into().unwrap();
append_big_digits_util(@new_value, ref byte_array, base_nz);
byte_array.append_byte(get_big_base_digit_representation(:digit_as_u8));
}

/// Converts a digit (0-9, A-Z) to its Ascii representation in a base > 10.
Expand Down