Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic runnable to textual casm compilation. #6595

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 5, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the spr/main/02c2e77f branch 2 times, most recently from f20771c to 17849cf Compare November 7, 2024 07:47
@orizi orizi force-pushed the spr/main/19fd4b26 branch from f087f49 to 6b692ad Compare November 10, 2024 10:55
@orizi orizi force-pushed the spr/main/02c2e77f branch from 17849cf to e918382 Compare November 10, 2024 10:55
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 12 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the spr/main/02c2e77f branch from 917f9e6 to f884eaa Compare November 12, 2024 11:38
@orizi orizi force-pushed the spr/main/19fd4b26 branch from d4cacc4 to 831168d Compare November 12, 2024 11:38
@orizi orizi force-pushed the spr/main/02c2e77f branch 2 times, most recently from f4e1b42 to 94a59f0 Compare November 12, 2024 13:17
@orizi orizi changed the base branch from spr/main/19fd4b26 to main November 12, 2024 13:19
@orizi orizi enabled auto-merge November 12, 2024 13:19
@orizi orizi force-pushed the spr/main/02c2e77f branch from 94a59f0 to e18ac8a Compare November 12, 2024 13:27
@orizi orizi added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 0fcdfdf Nov 12, 2024
47 of 48 checks passed
@orizi orizi deleted the spr/main/02c2e77f branch November 14, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants