fix: remove 'assert_eq!' test_mode checks

[enitrat]

Following our discussion

[reviewable-StarkWare]

This change is 

[orizi]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @enitrat)

---

a discussion (no related file):
tagging @mkaput and @maciektr to validate that we are indeed only adding this plugin in tests - unless very specifically added.

[mkaput]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @maciektr, @mkaput, and @orizi)

---

a discussion (no related file):

Previously, orizi wrote…

tagging @mkaput and @maciektr to validate that we are indeed only adding this plugin in tests - unless very specifically added.

Until #6843 is merged and correctly integrated into the ecosystem, we still suffer from the transient nature of compiler plugins, i.e. snforge_std pulls assert macros, so all Foundry project have these macros available everywhere.

[maciektr]

Previously, mkaput (Marek Kaput) wrote…

Until #6843 is merged and correctly integrated into the ecosystem, we still suffer from the transient nature of compiler plugins, i.e. snforge_std pulls assert macros, so all Foundry project have these macros available everywhere.

If guarding on test target being present is too limiting, we should guard on target: 'starknet-contract' instead, and disallow compilation if this is enabled. This way we can use assert_eq outside of tests and still disallow using it in contracts.

[maciektr]

we are indeed only adding this plugin in tests

We are not adding it, users add it themselves explicitly, like this: https://github.com/OpenZeppelin/cairo-contracts/blob/39950b704feb356389c979c11d987d957409d0dc/packages/token/Scarb.toml#L32-L33

[mkaput]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)