Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro declaration syntax. #7075

Open
wants to merge 1 commit into
base: high-level-inline-macros
Choose a base branch
from

Conversation

gilbens-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 14 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 9 of 15 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)


crates/cairo-lang-parser/src/parser.rs line 1487 at r2 (raw file):

            SyntaxKind::TerminalDiv => self.take::<TerminalDiv>().into(),
            SyntaxKind::TerminalDivEq => self.take::<TerminalDivEq>().into(),
            SyntaxKind::TerminalDollar => self.take::<TerminalDollar>().into(),

should dollar be not fully part of the identifier?

Code quote:

            SyntaxKind::TerminalDollar => self.take::<TerminalDollar>().into(),

crates/cairo-lang-parser/src/parser.rs line 1861 at r2 (raw file):

    /// Parses an expr block, while allowing placeholder expressions. Restores the previous
    /// placeholder expression setting after parsing.
    fn parse_block_with_placeholders(&mut self) -> ExprBlockGreen {

doesn't this have exactly a single caller?

Code quote:

 parse_block_with_placeholders(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants