Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_warnings flag. #7079

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

ilyalesokhin-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/bin/cairo-execute/src/main.rs line 142 at r1 (raw file):

                args.build.executable.as_deref(),
                reporter,
                args.build.ignore_warnings,

this should be part of the reporter.

Code quote:

                args.build.ignore_warnings,

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-compiler/src/diagnostics.rs line 61 at r2 (raw file):

            callback: None,
            crate_ids: vec![],
            ignore_warnings: false,

maybe?
just to make this more apparent it basically overrides another flag.

Suggestion:

            ignore_all_warnings: false,

Copy link
Contributor Author

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-compiler/src/diagnostics.rs line 61 at r2 (raw file):

Previously, orizi wrote…

maybe?
just to make this more apparent it basically overrides another flag.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@ilyalesokhin-starkware ilyalesokhin-starkware added this pull request to the merge queue Jan 19, 2025
Merged via the queue into main with commit 2beda61 Jan 19, 2025
48 checks passed
@orizi orizi deleted the ilya/ignore_warnings branch January 19, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants