-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added None & Some to prelude #7154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @dean-starkware and @gilbens-starkware)
corelib/src/prelude/v2024_07.cairo
line 21 at r1 (raw file):
pub use crate::iter::{FromIterator, IntoIterator, Iterator}; pub use crate::{assert, bool, felt252, starknet, usize}; use crate::option::Option::{None, Some};
Add to all other preludes as well.
Code quote:
use crate::option::Option::{None, Some};
corelib/src/prelude/v2024_07.cairo
line 21 at r1 (raw file):
pub use crate::iter::{FromIterator, IntoIterator, Iterator}; pub use crate::{assert, bool, felt252, starknet, usize}; use crate::option::Option::{None, Some};
Suggestion:
use crate::option::Option::{None, Some};
use crate::result::Result::{Ok, Err};
8193829
to
8edc39c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)
corelib/src/prelude/v2024_07.cairo
line 21 at r1 (raw file):
Previously, orizi wrote…
Add to all other preludes as well.
Done.
corelib/src/prelude/v2024_07.cairo
line 21 at r1 (raw file):
pub use crate::iter::{FromIterator, IntoIterator, Iterator}; pub use crate::{assert, bool, felt252, starknet, usize}; use crate::option::Option::{None, Some};
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @gilbens-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
8edc39c
to
deeb581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
No description provided.