Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added None & Some to prelude #7154

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Conversation

dean-starkware
Copy link
Collaborator

No description provided.

@dean-starkware dean-starkware marked this pull request as ready for review January 24, 2025 12:18
@reviewable-StarkWare
Copy link

This change is Reviewable

@dean-starkware dean-starkware changed the title added None & Some added None & Some to prelude Jan 24, 2025
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @dean-starkware and @gilbens-starkware)


corelib/src/prelude/v2024_07.cairo line 21 at r1 (raw file):

pub use crate::iter::{FromIterator, IntoIterator, Iterator};
pub use crate::{assert, bool, felt252, starknet, usize};
use crate::option::Option::{None, Some};

Add to all other preludes as well.

Code quote:

use crate::option::Option::{None, Some};

corelib/src/prelude/v2024_07.cairo line 21 at r1 (raw file):

pub use crate::iter::{FromIterator, IntoIterator, Iterator};
pub use crate::{assert, bool, felt252, starknet, usize};
use crate::option::Option::{None, Some};

Suggestion:

use crate::option::Option::{None, Some};
use crate::result::Result::{Ok, Err};

@dean-starkware dean-starkware force-pushed the dean/prelude_Option_variants branch from 8193829 to 8edc39c Compare January 24, 2025 15:07
Copy link
Collaborator Author

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @orizi)


corelib/src/prelude/v2024_07.cairo line 21 at r1 (raw file):

Previously, orizi wrote…

Add to all other preludes as well.

Done.


corelib/src/prelude/v2024_07.cairo line 21 at r1 (raw file):

pub use crate::iter::{FromIterator, IntoIterator, Iterator};
pub use crate::{assert, bool, felt252, starknet, usize};
use crate::option::Option::{None, Some};

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @gilbens-starkware)

Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@dean-starkware dean-starkware force-pushed the dean/prelude_Option_variants branch from 8edc39c to deeb581 Compare January 25, 2025 04:28
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@dean-starkware dean-starkware added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit 4022ede Jan 25, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants