chore: tables attached to domain description in load stage is not authorized starting from 1.2.0 but a config migration is automatically done ## Summary #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiboun
force-pushed
the
improve/remove-tables-deprecation
branch
2 times, most recently
from
3d94fdf to
f965331
Compare
…horized starting from 1.2.0 but a config migration is automatically done
tiboun
force-pushed
the
improve/remove-tables-deprecation
branch
from
f965331 to
8743e3b
Compare
hayssams
approved these changes
May 31, 2024
| @@ -231,6 +234,7 @@ case class LoadDesc(version: Int, load: Domain) | |||
|
|
|||
| def asDot(includeAllAttrs: Boolean, fkTables: Set[String]): String = { | |||
| tables | |||
| .sortBy(_.name) | |||
There was a problem hiding this comment.
sortBy(_.getFinaleName) probably
There was a problem hiding this comment.
This has no importance regarding rendering I think. It was introduced here in order to have an determinist output for unit test assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.