-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for number/float32/base/signbit
#3399
Conversation
Check out the workflow failures. E.g., the lint step of
tells us that several needed fields are not set and should be added. |
@Planeshifter I have added the essential files in the dependency tree of package.json.
|
Coverage Report
The above coverage report was generated for the changes in this PR. |
@Planeshifter All CI checks are passing pls review it. I am going to need this for implementing |
@Neerajpathak07 Wil try taking a look and review tonight. |
lib/node_modules/@stdlib/number/float32/base/signbit/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/number/float32/base/signbit/manifest.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
Looks pretty good to me. manifest.json
will need some updates. @kgryte, you mind taking final look please and then merge the PR after the comments have been addressed?
@Planeshifter Thank you for the review. |
/stdlib update-copyright-years |
/stdlib merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a bit of clean-up, this PR now LGTM.
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
PR-URL: stdlib-js#3399 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]> Co-authored-by: stdlib-bot <[email protected]>
Resolves #3397
Description
This pull request:
number/float32/base/signbit
Related Issues
This pull request:
number/float32/base/signbit
#3397 & [RFC]: Add C implementations to base special math functions (tracking issue) #649Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers