feat: add C implementation for `@stdlib/stats/base/dists/lognormal/logcdf` #4716

saurabhraghuvanshii · 2025-01-12T10:31:19Z

Resolves #3750 .

Description

What is the purpose of this pull request?

This pull request:

Add C implementation for @stdlib/stats/base/dists/lognormal/logcdf

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/lognormal/logcdf #3750

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

test case failed , I try multiple things.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

saurabhraghuvanshii · 2025-01-12T10:54:52Z

some errors are showing in readme section, And I don't know to tackle with that, I need help and review and Tests are failed as I done every type of possible solution by my side .

saurabhraghuvanshii · 2025-01-12T13:48:37Z

@Planeshifter @kgryte review this , I have some doubt with this.

Neerajpathak07 · 2025-01-12T17:22:27Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/src/main.c

+* double y = stdlib_base_lognormal_logcdf( 2.0, 0.0, 1.0 );
+* // returns ~-0.2799
+*/
+double stdlib_base_dists_lognormal_logcdf( const double x, const double mu, const double sigma ) {


@saurabhraghuvanshii The test cases are throwing errors because your implementation for main.c file does not resonate with the lib/main.js
According to the lib/main.js you'll be needing C implementations for nlogcdf

means return NINF / ln(x), if yes then how import ln it show there is no directory

Neerajpathak07 · 2025-01-12T17:24:36Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/src/main.c

+		stdlib_base_is_nan( sigma ) ||
+		sigma <= 0.0
+	) {
+		return 0.0 / 0.0; // NaN


it should be returning NINF when true and

ln(x)

while false

`#include "stdlib/stats/base/dists/lognormal/logcdf.h"
#include "stdlib/math/base/special/ln.h"
#include "stdlib/constants/float64/ninf.h"

/**

Returns the logcdf for a lognormal distribution with mean mu and standard deviation sigma.

@param x input value

@param mu mean

@param sigma standard deviation

@return logcdf

@example

double y = stdlib_base_lognormal_logcdf( 2.0, 0.0, 1.0 );

// returns ~-0.2799
*/
double stdlib_base_dists_lognormal_logcdf( const double x, const double mu, const double sigma ) {
double lx = ( x <= 0.0 ) ? ninf : ln( x );
return nlogcdf( lx, mu, sigma );
}
`
error on building

fatal error: stdlib/math/base/special/ln.h: No such file or directory

did you add those header files in manifest.json also that's not how you write ninf it should be STDLIB_CONSTANT_FLOAT64_NINF

Similarly instead of ln(x) write stdlib_base_ln(x)
same goes for nlogcdf

same error happen

can you go through files annd check why all this happens

I am comiting with new changes check it .

now you can check,

saurabhraghuvanshii · 2025-01-12T22:38:51Z

I have to clean up , I don't how all these commit comes from

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

Neerajpathak07 · 2025-01-13T07:21:13Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/manifest.json

+        "dependencies": [
+          "@stdlib/math/base/napi/binary",
+          "@stdlib/math/base/assert/is-nan",
+          "@stdlib/math/base/special/exp"


remove is-nan and exp and add the header files for ln and NINF

Neerajpathak07 · 2025-01-13T07:22:28Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/manifest.json

+          "@stdlib/math/base/special/exp",
+          "@stdlib/math/base/special/asin",
+          "@stdlib/math/base/special/sqrt",
+          "@stdlib/constants/float64/pi"


you'll have to remove all of these as it has not been used anywhere instead add the files suggested above.

Neerajpathak07 · 2025-01-13T07:26:18Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/src/main.c

+#include "stdlib/stats/base/dists/lognormal/logcdf.h"
+#include "stdlib/math/base/special/ln.h"
+#include "stdlib/constants/float64/ninf.h"
+


need to add #include "stdlib/stats/base/dists/normal/logcdf.h" in order to reference stdlib_base_dists_normal_logcdf
But stdlib/stats/base/dists/normal/logcdf does not have C implementation so this PR will have to wait till we have that.
You can go ahead and draft this PR for the time being

Neerajpathak07 · 2025-01-13T07:27:39Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/src/main.c

+*/
+double stdlib_base_dists_lognormal_logcdf( const double x, const double mu, const double sigma ) {
+	double lx = ( x <= 0.0 ) ? STDLIB_CONSTANT_FLOAT64_NINF : stdlib_base_ln( x );
+	return stdlib_base_nlogcdf( lx, mu, sigma );


This reference is incorrect it should be stdlib_base_dists_normal_logcdf as it comes from stats/base/dists/normal/logcdf

but we implement for stats/base/dists/lognormal/logcdf

I'm sorry I didn't understand your point

sorry, I take it wrong, for now I am leaving this pr . in future see

Though I would suggest you to draft this PR for now

today I try once more and change in manifest from binary to ternary so old error no showing new error are code: 'MODULE_NOT_FOUND', requireStack: [ '/home/saurabh/Gsoc/stdlib-gs/lib/node_modules/@stdlib/utils/library-manifest/lib/main.js', '/home/saurabh/Gsoc/stdlib-gs/lib/node_modules/@stdlib/utils/library-manifest/lib/index.js', '/home/saurabh/Gsoc/stdlib-gs/lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/[eval]' ] }

Neerajpathak07 · 2025-01-15T09:05:58Z

lib/node_modules/@stdlib/math/base/special/ln/manifest.json

@@ -38,12 +38,9 @@
      "libraries": [],
      "libpath": [],
      "dependencies": [
-        "@stdlib/math/base/napi/unary",


There is no need to make these changes in the manifest.json of math/base/special/ln,

there is nothing show like this in manifest.json of math/base/special/ln in repo

What I meant was that there was no need to change the block of code in math/base/special/ln so it will be good to revert it back.

It is depends on base/dists/normal/logcdf , which is not implement at that moment.

Neerajpathak07 · 2025-01-15T09:07:20Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/manifest.json

+        "libpath": [],
+        "dependencies": [
+          "@stdlib/math/base/napi/binary",
+          "@stdlib/math/base/assert/is-nan",


Suggested change

"@stdlib/math/base/assert/is-nan",

"@stdlib/math/base/special/ln",

This is what I meant by adding the header file for manifest.json

Neerajpathak07 · 2025-01-15T09:09:07Z

lib/node_modules/@stdlib/stats/base/dists/lognormal/logcdf/manifest.json

+        "dependencies": [
+          "@stdlib/math/base/napi/binary",
+          "@stdlib/math/base/assert/is-nan",
+          "@stdlib/math/base/special/exp"


Suggested change

"@stdlib/math/base/special/exp"

"@stdlib/constants/float64/ninf"

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 12, 2025

Neerajpathak07 reviewed Jan 12, 2025

View reviewed changes

saurabhraghuvanshii added 3 commits January 13, 2025 12:33

feat: add C implementation for base/dists/lognormal/logcdf

469aa3a

saurabhraghuvanshii force-pushed the lognormal-logcdf branch from 2bfa5ac to e025c63 Compare January 13, 2025 07:13

Neerajpathak07 reviewed Jan 13, 2025

View reviewed changes

saurabhraghuvanshii marked this pull request as draft January 13, 2025 12:46

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 13, 2025

Neerajpathak07 reviewed Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add C implementation for `@stdlib/stats/base/dists/lognormal/logcdf` #4716

feat: add C implementation for `@stdlib/stats/base/dists/lognormal/logcdf` #4716

saurabhraghuvanshii commented Jan 12, 2025

saurabhraghuvanshii commented Jan 12, 2025

saurabhraghuvanshii commented Jan 12, 2025

Neerajpathak07 Jan 12, 2025

saurabhraghuvanshii Jan 12, 2025 •

edited

Loading

Neerajpathak07 Jan 12, 2025 •

edited

Loading

saurabhraghuvanshii Jan 12, 2025 •

edited

Loading

saurabhraghuvanshii Jan 12, 2025

Neerajpathak07 Jan 12, 2025 •

edited

Loading

Neerajpathak07 Jan 12, 2025 •

edited

Loading

saurabhraghuvanshii Jan 12, 2025

saurabhraghuvanshii Jan 12, 2025

saurabhraghuvanshii Jan 12, 2025

Neerajpathak07 Jan 13, 2025

saurabhraghuvanshii Jan 13, 2025

saurabhraghuvanshii commented Jan 12, 2025

Neerajpathak07 Jan 13, 2025

Neerajpathak07 Jan 13, 2025

Neerajpathak07 Jan 13, 2025 •

edited

Loading

Neerajpathak07 Jan 13, 2025 •

edited

Loading

saurabhraghuvanshii Jan 13, 2025

saurabhraghuvanshii Jan 13, 2025

Neerajpathak07 Jan 13, 2025

saurabhraghuvanshii Jan 13, 2025 •

edited

Loading

Neerajpathak07 Jan 13, 2025

saurabhraghuvanshii Jan 14, 2025

Neerajpathak07 Jan 15, 2025

saurabhraghuvanshii Jan 15, 2025

Neerajpathak07 Jan 15, 2025

saurabhraghuvanshii Jan 15, 2025

Neerajpathak07 Jan 15, 2025 •

edited

Loading

Neerajpathak07 Jan 15, 2025

	"@stdlib/math/base/assert/is-nan",
	"@stdlib/math/base/special/ln",

	"@stdlib/math/base/special/exp"
	"@stdlib/constants/float64/ninf"

feat: add C implementation for @stdlib/stats/base/dists/lognormal/logcdf #4716

Are you sure you want to change the base?

feat: add C implementation for @stdlib/stats/base/dists/lognormal/logcdf #4716

Conversation

saurabhraghuvanshii commented Jan 12, 2025

Description

Related Issues

Questions

Other

Checklist

saurabhraghuvanshii commented Jan 12, 2025

saurabhraghuvanshii commented Jan 12, 2025

Choose a reason for hiding this comment

saurabhraghuvanshii Jan 12, 2025 • edited Loading

Choose a reason for hiding this comment

Neerajpathak07 Jan 12, 2025 • edited Loading

Choose a reason for hiding this comment

saurabhraghuvanshii Jan 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Neerajpathak07 Jan 12, 2025 • edited Loading

Choose a reason for hiding this comment

Neerajpathak07 Jan 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saurabhraghuvanshii commented Jan 12, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Neerajpathak07 Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

Neerajpathak07 Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saurabhraghuvanshii Jan 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Neerajpathak07 Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat: add C implementation for `@stdlib/stats/base/dists/lognormal/logcdf` #4716

feat: add C implementation for `@stdlib/stats/base/dists/lognormal/logcdf` #4716

saurabhraghuvanshii Jan 12, 2025 •

edited

Loading

Neerajpathak07 Jan 12, 2025 •

edited

Loading

saurabhraghuvanshii Jan 12, 2025 •

edited

Loading

Neerajpathak07 Jan 12, 2025 •

edited

Loading

Neerajpathak07 Jan 12, 2025 •

edited

Loading

Neerajpathak07 Jan 13, 2025 •

edited

Loading

Neerajpathak07 Jan 13, 2025 •

edited

Loading

saurabhraghuvanshii Jan 13, 2025 •

edited

Loading

Neerajpathak07 Jan 15, 2025 •

edited

Loading