Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lapack/base/zlacgv #4725

Merged
merged 6 commits into from
Jan 18, 2025
Merged

feat: add lapack/base/zlacgv #4725

merged 6 commits into from
Jan 18, 2025

Conversation

rreusser
Copy link
Member

@rreusser rreusser commented Jan 12, 2025

Towards #2464

Description

What is the purpose of this pull request?

This pull request adds a BLAS-like LAPACK module for computing the complex conjugate of a vector.

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

This commit adds a BLAS-like LAPACK module for computing the
complex conjugate of a vector.

Fixes: stdlib-js#2464
@stdlib-bot stdlib-bot added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label Jan 12, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 15, 2025

Coverage Report

Package Statements Branches Functions Lines
lapack/base/zlacgv $\color{green}267/267$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}267/267$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@rreusser rreusser marked this pull request as ready for review January 15, 2025 17:53
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 15, 2025
@rreusser
Copy link
Member Author

rreusser commented Jan 15, 2025

Hmm, no luck compiling the native add-on. Maybe I jumped the gun in blindly applying this to a LAPACK-namespaced module and expecting it to work without additional configuration work.

make install-node-addons NODE_ADDONS_PATTERN="lapack/base/zlacgv"
Cleaning add-on: /Users/rreusser/gh/stdlib-js/stdlib/lib/node_modules/@stdlib/lapack/base/zlacgv
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | darwin | arm64
gyp info ok 

Building add-on: /Users/rreusser/gh/stdlib-js/stdlib/lib/node_modules/@stdlib/lapack/base/zlacgv
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | darwin | arm64
(node:71357) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
gyp info find Python using Python version 3.12.7 found at "/Users/rreusser/gh/stdlib-js/stdlib/env/bin/python3"
gyp info spawn /Users/rreusser/gh/stdlib-js/stdlib/env/bin/python3
gyp info spawn args [
gyp info spawn args   '/Users/rreusser/gh/stdlib-js/stdlib/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/rreusser/gh/stdlib-js/stdlib/lib/node_modules/@stdlib/lapack/base/zlacgv/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/rreusser/gh/stdlib-js/stdlib/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/rreusser/Library/Caches/node-gyp/22.11.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/rreusser/Library/Caches/node-gyp/22.11.0',
gyp info spawn args   '-Dnode_gyp_dir=/Users/rreusser/gh/stdlib-js/stdlib/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/Users/rreusser/Library/Caches/node-gyp/22.11.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/Users/rreusser/gh/stdlib-js/stdlib/lib/node_modules/@stdlib/lapack/base/zlacgv',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  RULE binding_gyp_addon_target_compile_fortran_linux_0 Release/obj.target/addon/geni/zlacgv.o
  CC(target) Release/obj.target/addon/src/zlacgv_f.o
  CC(target) Release/obj.target/addon/../../../blas/base/shared/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-int64/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/is-type/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/equal-types/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-strided-complex128array/src/main.o
  CC(target) Release/obj.target/addon/../../../napi/argv-float64array/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/equal-typedarray-types/src/main.o
  CC(target) Release/obj.target/addon/../../../assert/napi/is-typedarray/src/main.o
  CC(target) Release/obj.target/addon/../../../complex/float64/ctor/src/main.o
  CC(target) Release/obj.target/addon/../../../complex/float32/ctor/src/main.o
  SOLINK_MODULE(target) Release/addon.node
clang++: error: no such file or directory: 'Release/obj.target/addon/src/addon.o'
make[1]: *** [Release/addon.node] Error 1

@rreusser rreusser marked this pull request as draft January 15, 2025 18:21
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 15, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@rreusser rreusser marked this pull request as ready for review January 15, 2025 18:59
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 15, 2025
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte
Copy link
Member

kgryte commented Jan 18, 2025

@rreusser Yeah, need to do a PoC first for compiling native add-ons in LAPACK. I don't think there should be much different, but TBD.

@kgryte kgryte self-requested a review January 18, 2025 02:34
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Jan 18, 2025
@kgryte kgryte changed the title feat: add lapack/base/zlacgv feat: add lapack/base/zlacgv Jan 18, 2025
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @rreusser!

@kgryte kgryte merged commit 4e3292d into stdlib-js:develop Jan 18, 2025
29 checks passed
@rreusser rreusser deleted the zlacgv-2 branch January 18, 2025 16:46
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 18, 2025
PR-URL: stdlib-js#4725
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
PR-URL: stdlib-js#4725
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
PR-URL: stdlib-js#4725
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants