Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update c implementation for math/base/special/cabs2f #4767

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

refactor: update c implementation for math/base/special/cabs2f #4767

wants to merge 7 commits into from
+659 −69

Conversation

vivekmaurya001
Copy link
Contributor

Description

  • refactors C implementation for @stdlib/math/base/special/cabs2f along with relevant tests, benchmarks and examples to follow latest conventions
  • added test.native.js, benchmark.native.js, addon file , native.js
  • updated the readme file , package.json , benchmark.c , examples.c
  • updated the initial test file to use absf instead of abs

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

vivekmaurya001 and others added 6 commits January 15, 2025 11:06
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
0895ff9 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
97cc4ae
@vivekmaurya001
Merge branch 'stdlib-js:develop' into math/cabs2f
18bd3a6
@vivekmaurya001
Merge branch 'stdlib-js:develop' into math/cabs2f
ded25e7
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
1954bd5 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001
feat(add c implementation): add math/base/special/cabs2f
dadf055 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001 vivekmaurya001 marked this pull request as draft January 15, 2025 17:14
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jan 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cabs2f $\color{green}143/143$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}143/143$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 15, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 15, 2025
@vivekmaurya001 vivekmaurya001 marked this pull request as ready for review January 15, 2025 17:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 15, 2025
@vivekmaurya001
Copy link
Contributor Author

good evening @gunjjoshi , please give this a review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivekmaurya001 @stdlib-bot