Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add STDLIB_MATH_BASE_NAPI_MODULE_III_D macro in math/base/napi/ternary #4854

Closed

Conversation

anandkaranubc
Copy link
Contributor

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • adds STDLIB_MATH_BASE_NAPI_MODULE_III_D macro in math/base/napi/ternary

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 22, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/napi/ternary $\color{green}155/155$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}155/155$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Jan 22, 2025

@anandkaranubc Sorry. I just refactored math/base/napi/ternary. Would you mind updating this PR accordingly?

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 22, 2025
@anandkaranubc
Copy link
Contributor Author

@anandkaranubc Sorry. I just refactored math/base/napi/ternary. Would you mind updating this PR accordingly?

On it!

@anandkaranubc anandkaranubc deleted the feat/napi-iii-d branch January 22, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants